Humidity API#30
Closed
DanutAldea wants to merge 8 commits intoUPB-CS-OpenSourceUpstream:masterfrom
DanutAldea:humidity_api
Closed
Humidity API#30DanutAldea wants to merge 8 commits intoUPB-CS-OpenSourceUpstream:masterfrom DanutAldea:humidity_api
DanutAldea wants to merge 8 commits intoUPB-CS-OpenSourceUpstream:masterfrom
DanutAldea:humidity_api
Conversation
alexandruradovici
requested changes
May 2, 2023
apis/humidity/src/lib.rs
Outdated
|
|
||
| /// Initiate a synchronous humidity measurement. | ||
| /// Returns Ok(humidity_value) if the operation was successful | ||
| /// humidity_value is returned in hundreds of centigrades |
There was a problem hiding this comment.
What is the measurement unit returned?
alexandruradovici
requested changes
May 2, 2023
apis/humidity/src/lib.rs
Outdated
| pub fn read_sync() -> Result<u32, ErrorCode> { | ||
| let listener: Cell<Option<(u32,)>> = Cell::new(None); | ||
| share::scope(|subscribe| { | ||
| if let Ok(()) = Self::register_listener(&listener, subscribe) { |
There was a problem hiding this comment.
This is incorrect. This function should return the error that either subscribe or read return.
alexandruradovici
requested changes
May 4, 2023
src/lib.rs
Outdated
| Error, GpioInterruptListener, GpioState, InputPin, OutputPin, PinInterruptEdge, Pull, | ||
| PullDown, PullNone, PullUp, | ||
| }; | ||
| pub use gpio::{Error, GpioInterruptListener, GpioState, InputPin, OutputPin, PinInterruptEdge, Pull, PullDown, PullNone, PullUp}; |
There was a problem hiding this comment.
Suggested change
| pub use gpio::{Error, GpioInterruptListener, GpioState, InputPin, OutputPin, PinInterruptEdge, Pull, PullDown, PullNone, PullUp}; | |
| pub use gpio::{ | |
| Error, GpioInterruptListener, GpioState, InputPin, OutputPin, PinInterruptEdge, Pull, | |
| PullDown, PullNone, PullUp, | |
| }; |
I ran cargo fmt and this is the formatted source.
alexandruradovici
requested changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12
Based on alex's previous work from here
Heavily inspired from the work done #5
This PR would ad the api, an exemple, fake driver and tests.